Github corrupting .png files on download
After doing some reading and some testing that I carried out on our OGanttProjectManager Library on github, I have figured out that a additional line needs to be added to .gitattributes so the file now reads
# Declare files that will always have CRLF line endings on checkout.
* .omh text eol=crlf
# Prevent png images from being normalized
* .png -text
However just changing .gitattributes was not enough, I also had to re-export the original library so that the repository via the Github desktop app received a fresh copy of the entire source. Now when I download OGanttProjectManager from github and import the JSON, everything is fine.
Alex, perhaps this needs adding to your documentation on omnis.ci.
I will now go and update all our other libraries with this change.
> On 15 Feb 2018, at 22:44, Michael Monschau <firstname.lastname@example.org> wrote:
> Hi $all,
> Just discovered that some of our libraries we uploaded contain .png files in the src, such as images from #ICONS, but when downloading the source from github as a zip, the .png files are corrupt and will not import when trying to build the library from JSON, which fails. I followed Alex’s instructions and exported and reimported the libraries as a test, I never tried downloading the src once it was uploaded and importing from the downloaded source. Has anyone else tried to do that with libraries that contain images?
> I have created the correct .gitattributes file which contains the lines as specified in Alex’s document. But github should be able to handle .png files I would have thought. Does anyone have any ideas?
> Manage your list subscriptions at lists.omnis-dev.com
> Start a new message -> mailto:email@example.com